Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] l10n_es_aeat_mod592: Migration to 17.0 #4055

Merged
merged 9 commits into from
Mar 9, 2025
Merged

[17.0][MIG] l10n_es_aeat_mod592: Migration to 17.0 #4055

merged 9 commits into from
Mar 9, 2025

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Mar 3, 2025 •
edited
Loading

@pedrobaeza
Copy link
Member

/ocabot migration l10n_es_aeat_mod592

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 4, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 4, 2025
Open
51 tasks
@victoralmau victoralmau force-pushed the 17.0-mig-l10n_es_aeat_mod592 branch from 0f9bfe8 to 60e401a Compare March 4, 2025 07:44
@victoralmau victoralmau force-pushed the 17.0-mig-l10n_es_aeat_mod592 branch from 60e401a to 9e861ce Compare March 4, 2025 09:12
@victoralmau victoralmau mentioned this pull request Mar 4, 2025
Merged
@victoralmau victoralmau force-pushed the 17.0-mig-l10n_es_aeat_mod592 branch from 9e861ce to 8498016 Compare March 4, 2025 09:28
pedrobaeza
pedrobaeza approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-4055-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 8, 2025
@OCA-git-bot
Merge PR #4055 into 17.0
c32c0b5 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command /tmp/tmpbr7g98w_/bin/python -P -m build --wheel --outdir /tmp/tmpl1hvwfiv --no-isolation /tmp/tmpe_pl9kz9/l10n_es_aeat_mod592 failed with output:

* Getting build dependencies for wheel...
* Building wheel...
Traceback (most recent call last):
  File "/tmp/tmpbr7g98w_/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
    main()
  File "/tmp/tmpbr7g98w_/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
    json_out["return_val"] = hook(**hook_input["kwargs"])
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpbr7g98w_/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 280, in build_wheel
    return _build_backend().build_wheel(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpbr7g98w_/lib/python3.12/site-packages/whool/buildapi.py", line 194, in build_wheel
    return _build_wheel(Path.cwd(), Path(wheel_directory), editable=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmpbr7g98w_/lib/python3.12/site-packages/whool/buildapi.py", line 169, in _build_wheel
    _copy_to(addon_dir, odoo_addon_path)
  File "/tmp/tmpbr7g98w_/lib/python3.12/site-packages/whool/buildapi.py", line 71, in _copy_to
    shutil.copy(addon_dir / f, dstd)
  File "/usr/lib/python3.12/shutil.py", line 435, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/usr/lib/python3.12/shutil.py", line 260, in copyfile
    with open(src, 'rb') as fsrc:
         ^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpe_pl9kz9/l10n_es_aeat_mod592/"docs/R\\303\\251g. Fiscal Adquir. y Repres. (ADSIPLRA).csv"'

ERROR Backend subprocess exited when trying to invoke build_wheel

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-4055-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 9, 2025
@OCA-git-bot
Merge PR #4055 into 17.0
bbd1cc1 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command /tmp/tmppdsx21cs/bin/python -P -m build --wheel --outdir /tmp/tmpbs673pzc --no-isolation /tmp/tmplsy7qyj8/l10n_es_aeat_mod592 failed with output:

* Getting build dependencies for wheel...
* Building wheel...
Traceback (most recent call last):
  File "/tmp/tmppdsx21cs/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
    main()
  File "/tmp/tmppdsx21cs/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
    json_out["return_val"] = hook(**hook_input["kwargs"])
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmppdsx21cs/lib/python3.12/site-packages/pyproject_hooks/_in_process/_in_process.py", line 280, in build_wheel
    return _build_backend().build_wheel(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmppdsx21cs/lib/python3.12/site-packages/whool/buildapi.py", line 194, in build_wheel
    return _build_wheel(Path.cwd(), Path(wheel_directory), editable=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/tmppdsx21cs/lib/python3.12/site-packages/whool/buildapi.py", line 169, in _build_wheel
    _copy_to(addon_dir, odoo_addon_path)
  File "/tmp/tmppdsx21cs/lib/python3.12/site-packages/whool/buildapi.py", line 71, in _copy_to
    shutil.copy(addon_dir / f, dstd)
  File "/usr/lib/python3.12/shutil.py", line 435, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/usr/lib/python3.12/shutil.py", line 260, in copyfile
    with open(src, 'rb') as fsrc:
         ^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmplsy7qyj8/l10n_es_aeat_mod592/"docs/R\\303\\251g. Fiscal Adquir. y Repres. (ADSIPLRA).csv"'

ERROR Backend subprocess exited when trying to invoke build_wheel

Nicolás Ramos and others added 9 commits March 9, 2025 12:51
@pedrobaeza
[ADD] l10n_es_aeat_mod592: New module
4c64619 
Co-authored-by: Nicolás Ramos
@Christian-RB @javierjcf @pedrobaeza
[IMP] l10n_es_aeat_mod592: Misc changes
8deeb7a 
- Correciones básicas
- Búsqueda registros acquisiciones y dedducciones
- Intentar contemplar casos de fabricantes
- Traducciones y registros adquirientes
- Correciones v14
- Quitar Excel y correiones campos csv

Co-authored-by: javierjcf <[email protected]>
@victoralmau @pedrobaeza
[IMP] l10n_es_aeat_mod592: New module
0997725 
Changes done:
- Adding specific groups to view acquirer/manufacturers
- Code refactoring
- Sequence compatibility
- Reports
- Remove report_csv dependency
- Add search option to template fields
- Show the fields in product.template if there are no variants.
- Add tests

TT48472

[UPD] Update l10n_es_aeat_mod592.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-15.0/l10n-spain-15.0-l10n_es_aeat_mod592
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-l10n_es_aeat_mod592/
@victoralmau @pedrobaeza
[FIX] l10n_es_aeat_mod592: Compare if no weight with the correct deci…
70a0dfa 
…mal precision

TT52290
@victoralmau @pedrobaeza
[IMP] l10n_es_aeat_mod592: Definir digits a los campos kgs, no_recycl…
754a0fc 
…ing_kgs, product_uom_qty

TT52290
@victoralmau @pedrobaeza
[IMP] l10n_es_aeat_mod592: Definir datos correctos en el excel que se…
9fc90e3 
… exporta

Cambios hechos:
- Se añade el concepto y el product_description al método _get_csv_report_info() del mixin (necesario en ambos)
- Se añade el campo product_description al mixin (necesario en ambos)
- Los valores de Kilogramos y Kilogramos No Reciclados se deben definir con , como separador decimal
- Definir el valor del campo Fecha Hecho Contabilizado en formato: DD-MM-YYYY
- Adquiriente: Se define como Descripción Producto la descripción del producto en lugar de fiscal_acquirer
- Adquiriente: Se añade la columna Régimen fiscal (fiscal_acquirer)  después de la descripción de producto
- Adquiriente: Se mueven los campo Prov./Dest. al lugar adecuado, antes de Kilogramos

TT52986
@victoralmau @pedrobaeza
[IMP] l10n_es_aeat_mod592: Posibilidad de exportar csv
a5d6a49 
TT52986

[UPD] Update l10n_es_aeat_mod592.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-spain-15.0/l10n-spain-15.0-l10n_es_aeat_mod592
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-15-0/l10n-spain-15-0-l10n_es_aeat_mod592/
@victoralmau @pedrobaeza
[IMP] l10n_es_aeat_mod592: pre-commit auto fixes
399066b
@victoralmau @pedrobaeza
[MIG] l10n_es_aeat_mod592: Migration to 17.0
b9cab9e 
TT52330
@pedrobaeza pedrobaeza force-pushed the 17.0-mig-l10n_es_aeat_mod592 branch from 8498016 to b9cab9e Compare March 9, 2025 11:53
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-4055-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ba7790c into OCA:17.0 Mar 9, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 28d6446. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-l10n_es_aeat_mod592 branch March 9, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @Christian-RB