shouldRecycle not used in one spot

[valtron]

See: https://github.com/MithrilJS/mithril.js/blame/8b56c7091169c0fb057d7afac041a23a4700bcdb/render/render.js#L237

Changed in: 632677e#diff-000bdfae56251b0715111d2b18c9de3cR200

From the other changes in that commit, it looks like the line after should use shouldRecycle instead of recycling.

This "bug" causes components to get oninit'ed unnecessarily: see https://jsfiddle.net/3hnjft4u:

• run and open inspector
• delete items 1.1, 1.0 in that order
• check inspector output: the logged "oninit 1.3" is unnecessary

I'd gladly make a PR for this.

[pygy]

Thanks for the report!

At a glance, your analysis seems correct (this example uses a version of Mithril patched according to your suggestion and the problem subsides).

But it's getting late, I'll revisit this tomorrow or on monday (if someone else doesn't beat me to it).

[pygy]

Yup, PR welcome!