Adhere to follow_web_links setting when overriding context #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38.
The solution isn't 100% satisfying as it basically duplicates the categorization logic from
linkcheck
. It could perhaps be implemented more cleanly by exposing theCategory
enum but I'm not sure if that would be worth it. Let me know what you think!I added a test book which is a copy of the "all-green" book except with config and link texts that indicate what the expected result is.
TestRun
now optionally takes aConfig
to allow settingfollow_web_links
to false.