Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to follow_web_links setting when overriding context #46

Merged

Conversation

wonderfulspam
Copy link
Contributor

Closes #38.

The solution isn't 100% satisfying as it basically duplicates the categorization logic from linkcheck. It could perhaps be implemented more cleanly by exposing the Category enum but I'm not sure if that would be worth it. Let me know what you think!

I added a test book which is a copy of the "all-green" book except with config and link texts that indicate what the expected result is. TestRun now optionally takes a Config to allow setting follow_web_links to false.

@Michael-F-Bryan
Copy link
Owner

It could perhaps be implemented more cleanly by exposing the Category enum but I'm not sure if that would be worth it.

If it were any more complex than some_url.parse() then we'd definitely want to deduplicate the logic, but it should be fine for now.

I added a test book which is a copy of the "all-green" book except with config and link texts that indicate what the expected result is. TestRun now optionally takes a Config to allow setting follow_web_links to false.

This is awesome, thank you 🎉

@Michael-F-Bryan Michael-F-Bryan merged commit b2924b0 into Michael-F-Bryan:master Oct 26, 2020
@wonderfulspam wonderfulspam deleted the fix_follow_web_links branch October 26, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow-web-links broken?
2 participants