Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): lower TLS to v1.2 for downloading covers #3691

Merged

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Feb 27, 2025

Description

Some users are unable covers due to requiring TLS v1.3, so the requirement will be lowered for now.

Screenshot

Issues Fixed or Closed

Fixes #3583

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.61%. Comparing base (e3079da) to head (5478c66).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3691   +/-   ##
=======================================
  Coverage   11.61%   11.61%           
=======================================
  Files          92       92           
  Lines       17337    17337           
  Branches     8100     8100           
=======================================
  Hits         2013     2013           
  Misses      12833    12833           
  Partials     2491     2491           
Flag Coverage Δ
Linux 11.28% <ø> (ø)
Windows 13.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher merged commit f7190f5 into master Feb 28, 2025
37 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/http/lower-TLS-to-v1.2-for-downloading-covers branch February 28, 2025 14:51
qiin2333 pushed a commit to qiin2333/Sunshine-Foundation that referenced this pull request Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

curl error 35 when downloading covers
1 participant