E2E GH Action - patch/modifying

[elreydetoda]

So, I think there was an issue with this action: https://github.com/jakejarvis/hugo-build-action

Because the prod deployment works and after I swapped over to use the same docker image as the prod deployment everything worked fine. (from the hugo building perspective)

After that I adapted the action to properly use the pipenv (Pipfile + .lock) instead of the requirements.txt.

Next the tests were actually working and failing as expected! 😂 It was failing because the JB live link wasn't as expected from the tests, and because #317 was merged before #325 was merged (and #325 wasn't rebase'd on main) the tests were expecting the old URL. So I updated the reference to point to /live instead, and everything works now 😁 https://github.com/elreydetoda/jupiterbroadcasting.com/runs/8080987260?check_suite_focus=true

[gerbrent]

great 🔍 investigative work @elreydetoda ! I could tell it was working as expected - i.e. the E2E tests were finding a problem as configured, but didn't know how to inspect.... hope someone teaches me that at some point ; )

[elreydetoda]

great mag investigative work @elreydetoda ! I could tell it was working as expected - i.e. the E2E tests were finding a problem as configured, but didn't know how to inspect.... hope someone teaches me that at some point ; )

From a high level, this was pretty much my process:

1. I identified an error because of the error starting here: https://github.com/elreydetoda/jupiterbroadcasting.com/runs/8080911236?check_suite_focus=true#step:9:48
2. Then the line below it here says the actual value: https://github.com/elreydetoda/jupiterbroadcasting.com/runs/8080911236?check_suite_focus=true#step:9:49
3. So, I knew that the comparison of expected vs actual was not right.
4. You can see the expected dropdowns passed in here: https://github.com/elreydetoda/jupiterbroadcasting.com/runs/8080911236?check_suite_focus=true#step:9:29, and can see where it's got the jb-live.jb.net domain.
5. I went into conftest.py file, which is used to be a central location for passing in commonly shared value (i.e. all the dropdowns we're expecting, because that might be used by multiple tests), and changed it from the jb-live.jb.net to /live: https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/pull/353/files#diff-7dae78a00d8d69422a3bfbde96c7c5d794eede504a0df763853896a1ba1b5ff2R59

[gerbrent]

I don't understand the implications of pipenv enough (though aware we've implemented it elsewhere recently) so asking for reviewers:

[elreydetoda]

I don't understand the implications of pipenv enough (though aware we've implemented it elsewhere recently) so asking for reviewers:

Definitely feel free to still wait for the reviews, but just for some extra info this is what I mentioned to @kbondarev for why we should use pipenv: JupiterBroadcasting/show-scraper#11

[elreydetoda]

Converted to draft, because of weird bug that came up with the E2E tests: #383 (comment)

Going to redo how the E2E GH action works to hopefully make more consistent and have less quirks...

[gerbrent]

....did we find you in a rabbit hole?? ; )

[gerbrent]

#386

[elreydetoda]

....did we find you in a rabbit hole?? ; )

That's so funny you said those word! Look at what the title of my blog is: https://elrey.casa/blog (it's "The Rabbit Hole") 🤣

[elreydetoda]

alright... I think I've finally gotten it 🙃

Going to make a longer comment to explain things, but this will be what the final report will look like after merging: https://github.com/elreydetoda/jupiterbroadcasting.com/runs/8199597176

[elreydetoda]

putting back to draft till I have time to finish documenting things and make my long comment (almost ready 😅 )

[elreydetoda]

I re-worked some more things, and with my latest commit we shouldn't get failed tests from people submitting PRs, because it'll skip the upload reports thing. You can still go into the action and see the test results (plus it'll fail if the tests fail), but I think it keeps telling us that it's failing because they don't have permissions to write to the repo or something like that.

examples of failures:

• https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/runs/8207282787?check_suite_focus=true#step:6:26
• https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/runs/8221075206?check_suite_focus=true#step:11:33

[elreydetoda]

BTW, I merged to resolve the conflict instead of rebasing so that all my links to stuff from my comment above didn't break things.

[gerbrent]

Hey @elreydetoda - any thoughts on the best way to test this for us mere mortals?

I wonder if you'll say "a dev branch!" to which I would say LETS DO IT!! 💪🏻

[elreydetoda]

Lol, ya that'd probably be the easiest.

If that's the case though I might need to make a modification or two to the PR (so it properly triggers on the develop branch as well as main). I'll make that modification tonight, and I'll let you know when it's good to go.

I'll also need to change my target branch for the PR (since it's currently targeting main).

[elreydetoda]

Alright, @gerbrent I've created the develop branch, and now I'm pointing my PR to that branch. You'll need to still follow this accompanying documentation, so the containers build properly (or you could disable those actions from running if you want for now).

Here's what the workflow will look like:

• PR into develop - Patch/modifying e2e gh action elreydetoda/jupiterbroadcasting.com#13
  • Merge into develop:
    • develop containers being built: https://github.com/elreydetoda/jupiterbroadcasting.com/actions/runs/3042253566
    • E2E tests: https://github.com/elreydetoda/jupiterbroadcasting.com/actions/runs/3042253568
      • report: https://github.com/elreydetoda/jupiterbroadcasting.com/runs/8320186125
• PR into prod from develop: Develop elreydetoda/jupiterbroadcasting.com#14
  • Merge into develop:
    • prod containers being built: https://github.com/elreydetoda/jupiterbroadcasting.com/actions/runs/3042276766
    • E2E tests: https://github.com/elreydetoda/jupiterbroadcasting.com/actions/runs/3042276791
      • report: https://github.com/elreydetoda/jupiterbroadcasting.com/runs/8320252541

[elreydetoda]

BTW @gerbrent , if you want we can hop on a call and walk through the setup of this environment as well 😁 (whatever you're most comfortable with 🙂)

[gerbrent]

Merging this as Part A, with Part B involving some JB/ @ironicbadger involvement to handle deployment functionality. We will also need to sign up to quay.io in that process, so definitely more JB Action Required.

Onward!

[gerbrent]

@ironicbadger - care to link up w @elreydetoda to complete the final stages of this PR?