Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 🧪 improve integration test workflow order #1700

Merged
merged 4 commits into from
Sep 28, 2024

Conversation

JamesIves
Copy link
Owner

@JamesIves JamesIves commented Sep 28, 2024

Description

#1697 went missed during a release cycle because the integration tests ran before the major tag version tag updated. This change adjusts the flow so the integration tests run on a CRON, but also after the major tag is made using workflow_call. This ensures that the tests fail immediately without users having to report an issue like this, or before the scheduled tests find the issue.

Testing Instructions

N/A

Additional Notes

N/A

@github-actions github-actions bot added the test 🧪 Changes introduce new tests to the project. label Sep 28, 2024
@JamesIves JamesIves changed the title test: improve integration test workflow test: improve integration test workflow order Sep 28, 2024
@JamesIves JamesIves changed the title test: improve integration test workflow order test: 🧪 improve integration test workflow order Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (739329c) to head (d9edee2).
Report is 8 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1700   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files           7        7           
  Lines         299      299           
  Branches       83       83           
=======================================
  Hits          288      288           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesIves JamesIves self-assigned this Sep 28, 2024
@JamesIves JamesIves merged commit e3d9347 into dev Sep 28, 2024
17 checks passed
@JamesIves JamesIves deleted the feat-improve-int-flow branch September 28, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test 🧪 Changes introduce new tests to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant