services: migrate external tap to main repo (WIP)

[botantony]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Any feedback/suggestion is appreciated (help wanted label would be nice). For some reason I cannot generate .rbi file for dynamic methods:

$ /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.3.0/bin/tapioca dsl Homebrew::Cmd::Services
/opt/homebrew/Cellar/ruby/3.4.2/lib/ruby/3.4.0/rubygems.rb:262:in 'Gem.find_spec_for_exe': can't find gem tapioca (>= 0.a) with executable tapioca (Gem::GemNotFoundException)
        from /opt/homebrew/Cellar/ruby/3.4.2/lib/ruby/3.4.0/rubygems.rb:281:in 'Gem.activate_bin_path'
        from bin/tapioca:25:in '<main>'

Maybe I'm doing something wrong

partially resolves #19210

[MikeMcQuaid]

Maybe I'm doing something wrong

Can try brew typecheck --update or brew typecheck --update-all (can't remember which).

[MikeMcQuaid]

Wow, great work so far @botantony! Thanks for this.

[MikeMcQuaid]

Would be good to also move some of https://github.com/Homebrew/homebrew-services/tree/master/spec into Library/Homebrew/test too for some basic unit testing.

[botantony]

I tested some specs and it is probably easier to just write them from scratch. homebrew-services repo doesn't use strict types and as the result they "emulate" formula object with OpenStruct. I'll try to write new unit tests that test functions the proper way

[MikeMcQuaid]

@botantony It's ok to not use strict types here and even maintain the emulation for now. The goal is to have this merged with the code as close as possible to that in homebrew-services. Additional refactoring should be in a follow-up PR. Thanks 🙇🏻

[p-linnane]

Thanks for taking this on @botantony! Have loved seeing all of your great contributions lately!

[MikeMcQuaid]

Looking good @botantony! Think once the specs get ported over as as-is as possible: this should be good to merge!

[botantony]

does anyone have an idea why this test may fail?

  describe "#dest" do
    it "macOS - outputs the destination for the service file" do
      ENV["HOME"] = "/tmp_home"

      allow(Service::System).to receive_messages(launchctl?: true, systemctl?: false)
      expect(service.dest.to_s).to eq("/tmp_home/Library/LaunchAgents/homebrew.mysql.plist")
    end

    it "systemD - outputs the destination for the service file" do
      ENV["HOME"] = "/tmp_home"

      allow(Service::System).to receive_messages(launchctl?: false, systemctl?: true)
      expect(service.dest.to_s).to eq("/tmp_home/.config/systemd/user/homebrew.mysql.service")
    end
  end

shell output:

  1) Service::FormulaWrapper#dest systemD - outputs the destination for the service file
     Failure/Error: expect(service.dest.to_s).to eq("/tmp_home/.config/systemd/user/homebrew.mysql.service")

       expected: "/tmp_home/.config/systemd/user/homebrew.mysql.service"
            got: "/tmp_home/Library/LaunchAgents/homebrew.mysql.service"

       (compared using ==)
     # ./test/services/formulae_wrapper_spec.rb:121:in `block (3 levels) in <top (required)>'

it tests formula_wrapper.rb

[MikeMcQuaid]

does anyone have an idea why this test may fail?

@botantony My best guess is something was being mocked successfully before but is not being mocked in the test now?

[botantony]

Oh, I found the issue, there's no need to set values in before block. Thank you Mike!

[botantony]

🤔

[Bo98]

The tap tests redefines opoo to stdout: https://github.com/Homebrew/homebrew-services/blob/5f26f05cf986f418d83931ce2085b44b4213a9d8/spec/spec_helper.rb#L123 whereas the regular behaviour puts it to stderr.

So you'll need to separate that output to check the root message under stderr and the success message under stdout

.to output(...).to_stdout
.and output(...).to_stderr