Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename aarch64_linux tag to arm64_linux #19188

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jan 31, 2025

Alternative to and closes #19183.

Lightly tested but it seems to work for a basic brew install at least.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is exactly what I had in mind. Thanks so much for this @Bo98, looks great! One tiny suggested documentation change; optional so feel free to take it or leave it.

@Bo98
Copy link
Member Author

Bo98 commented Feb 1, 2025

Been trying to ask around for opinions (just to make sure the majority agrees since I don't want to have to hack about backtracking this if anyone changes their mind) but FOSDEM is loud so haven't really been able to. Sean I think votes for this PR, while Carlo and Markus vote for the other PR. Could ask the TSC channel. Or maybe whole membership at AGM if preferred.

I don't really have a strong opinion either way - I understand the argument for both cases.

@MikeMcQuaid
Copy link
Member

@Bo98 We can wait and discuss this at/around the AGM tomorrow, no rush here 👍🏻

@MikeMcQuaid
Copy link
Member

Also, just to be explicit: this is a design/product decision more than a technical decision; it's about what "interface" we provide for our users/contributors/etc. and when/whether we want to be consistent/not with other platforms. As a result, I don't expect this to be a vote but instead be a discussion that we could have and then reach an outcome from that.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Feb 3, 2025
@MikeMcQuaid
Copy link
Member

Merging after final conversation with @carlocab and @ZhongRuoyu in person at the AGM where I made the final decision to go with ARM64 for now but we will reconsider using AARCH64 instead before we "officially support" the platform if we get sufficient community feedback indicating it's a better fit.

Merged via the queue into master with commit 7911948 Feb 3, 2025
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the arm64_linux-tag branch February 3, 2025 13:34
@Bo98
Copy link
Member Author

Bo98 commented Feb 3, 2025

we will reconsider using AARCH64 instead before we "officially support" the platform if we get sufficient community feedback

I will be pushing a Portable Ruby soon using the bottle tag picked here so would rather not be switching back and forth down the line.

@MikeMcQuaid
Copy link
Member

I will be pushing a Portable Ruby soon using the bottle tag picked here so would rather not be switching back and forth down the line.

We do not plan to switch back ere, was just being explicit after conversation with @ZhongRuoyu that we could do this is sufficient community feedback meant that we realised arm64 was an overwhelmingly bad decision. We are 👍🏻 to proceed with everything arm64 for the indefinite future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants