Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtime fixes 4 #3391

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Realtime fixes 4 #3391

merged 2 commits into from
Mar 7, 2025

Conversation

tinomarques
Copy link
Collaborator

@tinomarques tinomarques commented Mar 7, 2025

Fix: Simpler and safer isRealtimeSession detection
Fix: Changed sessions onRowSelect to new, rowLink themedTable param, ensuring minimum code and no effect on other tables

Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helicone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 5:48pm
helicone-bifrost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 5:48pm
helicone-eu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 5:48pm

Copy link
Contributor

promptless bot commented Mar 7, 2025

✅ No documentation updates required.

Copy link

fumedev bot commented Mar 7, 2025

Summary

  • Simplified and enhanced the detection logic for realtime sessions.
  • Updated the onRowSelect behavior in ThemedTable to use a new rowLink parameter, improving row selection without side effects.
  • Adjusted related session components to utilize the new rowLink approach for navigation.

@tinomarques tinomarques merged commit 6b38b97 into main Mar 7, 2025
7 of 9 checks passed
@tinomarques tinomarques deleted the realtime-fixes-4 branch March 7, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants