-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding possible improvements w/ fix merge #249
Conversation
@saracope Check this out - #132 (comment) |
Add improvement to cognitive complexity
@ftonato Can you merge in Master to get these checks to refire? |
@saracope I don't understood your request 😕 Are you suggesting to me create a new pull-request with my last commit to branch master?
The branch |
No. I'm saying that you need to merge in the latest update from Master. That should fix your failing Code Climate check. |
Hello @saracope, I have created two different pull-requests; First of them: #257 is a simple piece of code used to distribute responsibilities between methods that will help to improve the cognitive complexity and the last one #258 is your requested merge between master and ftonato-feature-improvements. You can accept both in the order in which they were created. |
Add improvement to cognitive complexity
Merge upstream/master into ftonato-feature-improvements
@ftonato CodeClimate is still failing here |
@saracope I'll check it out today and write you anything about it as soon as possible. |
refactor: fix cognitive complexity of adjustAssetPath method (other.js)
Summary
This PR fixes the following bugs/features
Closing issues
Fixes #132