Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding possible improvements w/ fix merge #249

Merged
merged 22 commits into from
Aug 12, 2019

Conversation

ftonato
Copy link
Contributor

@ftonato ftonato commented Jun 21, 2019

Summary

This PR fixes the following bugs/features

Closing issues
Fixes #132

@ftonato
Copy link
Contributor Author

ftonato commented Jun 21, 2019

@saracope Check this out - #132 (comment)

@saracope
Copy link
Contributor

@ftonato Can you merge in Master to get these checks to refire?

@ftonato
Copy link
Contributor Author

ftonato commented Jun 25, 2019

@saracope I don't understood your request 😕

Are you suggesting to me create a new pull-request with my last commit to branch master?

  • If this is not the case, you can delete this pull-request.

The branch ftonato-feature-improvements already is up-to-date with the master, like you can see below:

up-to-date

@saracope
Copy link
Contributor

No. I'm saying that you need to merge in the latest update from Master. That should fix your failing Code Climate check.

@ftonato
Copy link
Contributor Author

ftonato commented Jun 25, 2019

Hello @saracope,

I have created two different pull-requests;

First of them: #257 is a simple piece of code used to distribute responsibilities between methods that will help to improve the cognitive complexity and the last one #258 is your requested merge between master and ftonato-feature-improvements.

You can accept both in the order in which they were created.

saracope added 2 commits June 27, 2019 11:06
Add improvement to cognitive complexity
Merge upstream/master into ftonato-feature-improvements
@saracope
Copy link
Contributor

@ftonato CodeClimate is still failing here

@ftonato
Copy link
Contributor Author

ftonato commented Jun 27, 2019

@saracope I'll check it out today and write you anything about it as soon as possible.

@ftonato
Copy link
Contributor Author

ftonato commented Jun 28, 2019

Hello,

@saracope You need to merge #260 issue and you'll finally be available to merge this PR :)

refactor: fix cognitive complexity of adjustAssetPath method (other.js)
@saracope saracope merged commit 8a211bb into master Aug 12, 2019
@saracope saracope deleted the ftonato-feature-improvements branch August 12, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perf improvements and cleanups
2 participants