Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting #230

Merged
merged 4 commits into from
Jun 18, 2019
Merged

Fix linting #230

merged 4 commits into from
Jun 18, 2019

Conversation

saracope
Copy link
Contributor

@saracope saracope commented Jun 12, 2019

Summary

This PR fixes/implements the following bugs/features

  • Fix linting issues
  • Add lint script to ci

Note: This is an incremental improvement. Some items need further review and so were switched from "error" to "warn" (a backlog card was also created for this)

Deployed to staging for testing.

BEFORE
Screen Shot 2019-06-12 at 4 44 38 PM
.
.
.
AFTER
Screen Shot 2019-06-12 at 4 43 35 PM

@CourtneyBrousseau
Copy link

🙌🙌🙌

Copy link

@CourtneyBrousseau CourtneyBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, wow! Second of all, this all works locally for me as well. I also see the 124 warnings but there are no red errors anymore. npm run test also ran successfully (but still has 1 failing test which I might try to take a look at today).

@saracope saracope merged commit 3647ecd into master Jun 18, 2019
@saracope saracope deleted the sc_fix-linting branch June 18, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants