Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Tag Manager to <head> #223

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Conversation

CourtneyBrousseau
Copy link

Summary

Add Google Tag Manager script directly to head of index.html instead of injecting it so that it is compatible with the Google Tag Assistant Chrome Extension

Motivation

This refactor ensures that our team and contributors can use the Google Tag Assistant Chrome Extension to test our integration with the Digital Analytics Program (DAP). The old method of integrating Google Tag Manager via injection was meant to prevent bots from influencing our analytics data (by delaying analytics tracking for 3 seconds) but this prevented the Google Tag Assistant from working

Test plan (required)

Run npm run test. All tests pass (except for one which is also failing on master)

@saracope saracope merged commit 9c4cebc into master Jun 10, 2019
@saracope saracope deleted the cb_google-tag-manager-refactor branch June 10, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants