Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created CODE_GOV_CONFIG_JSON env variable #123

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

DanielJDufour
Copy link
Contributor

A similar PR may already be submitted!
Please search among the Pull request before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

For more information, see the CONTRIBUTING guide.

Summary

This PR fixes/implements the following bugs/features

  • Creates CODE_GOV_CONFIG_JSON environmental variable that points to the re-users site configuration JSON file
  • Replaced " with ' per ESLint standard

Explain the motivation for making this change. What existing problem does the pull request solve?
This solves the problem that potential re-users would have to fork code-gov-front-end and manage syncing with the upstream repo. For example, if we changed a file in the main code-gov-front-end repo, that could overwrite their changes in their own version if they run git pull upstream master

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
image

@DanielJDufour DanielJDufour requested a review from a team December 15, 2018 00:29
Copy link

@froi froi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Checked out the branch and tested locally. I like the change to override the location of the site config file.

@DanielJDufour DanielJDufour merged commit 4a7a4e9 into master Dec 16, 2018
@DanielJDufour DanielJDufour deleted the CreateEnvVariableForConfigJSON branch December 16, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants