Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds unhealthy events reason #5157

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Feb 24, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Moves health events hook to FeatureRow component
  • Unhealthy Warning uses less props and shows amount of unhealthy events
  • Fix feature modal not updating url when opening for 1st time
  • Adds feature health tab and lists unhealthy events
Screen.Recording.2025-02-24.at.11.13.28.mov
Screenshot 2025-02-25 at 17 52 46

How did you test this code?

Regression tests

Please describe.

@tiagoapolo tiagoapolo self-assigned this Feb 24, 2025
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:23pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:23pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 6:23pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Feb 24, 2025
Copy link
Contributor

github-actions bot commented Feb 24, 2025

Uffizzi Preview deployment-61257 was deleted.

Copy link
Contributor

github-actions bot commented Feb 24, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5157 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5157 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5157 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5157 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5157 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5157 Finished ✅ Results

@tiagoapolo
Copy link
Contributor Author

Tested with Grafana provider and have a bit of feedback:

  1. I think we can benefit from having corresponding links to documentation for every provider under Project Feature Health tab (when creating webhook links):

Along with displaying the webhook link, we can communicate something along the lines of:

Follow the documentation to configure your provider for alerting.

  1. I think we don't have to collapse the text blocks by default unless they're really long?
  2. For some reason, the links are center-aligned and don't look like they do in the video.

My browser: Chrome 132

image
  1. IMO we should have provider documentation in the settings page where we configure the provider
  2. We can display the most recent one uncollapsed and all the others collapsed, I guess we normally want to check the latest event first and the check the others

@kyle-ssg
Copy link
Member

kyle-ssg commented Feb 26, 2025

  1. IMO we should have provider documentation in the settings page where we configure the provider

Agree, but I imagine it's relevant to show the provider docs for the alert that's showing if we can next to the alert rather than 1 big list? Since I imagine an alert can be due to the configuration.

  1. We can display the most recent one uncollapsed and all the others collapsed, I guess we normally want to check the latest event first and the check the others

We have loads of real-estate on that tab so yeah most recent then expandable others.

@tiagoapolo
Copy link
Contributor Author

  1. IMO we should have provider documentation in the settings page where we configure the provider

Agree, but I imagine it's relevant to show the provider docs for the alert that's showing if we can next to the alert rather than 1 big list? Since I imagine an alert can be due to the configuration.

I say we can leave the docs reference in the settings page and if we find that we need to place it in the feature health tab in feature panel we figure a way of placing it there

@tiagoapolo tiagoapolo requested a review from khvn26 February 26, 2025 15:33
@flagsmith flagsmith bot added the flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith label Feb 26, 2025
Copy link

flagsmith bot commented Feb 26, 2025

Flagsmith feature linked: feature_health
Default Values:

Environment Enabled Value Last Updated (UTC)
Production ❌ Disabled 2025-01-30 13:34:44
Staging ❌ Disabled 2025-02-24 22:13:04

Segment flagsmith_team values:

Environment Enabled Value Last Updated (UTC)
Staging ✅ Enabled 2025-02-24 22:13:04
Demo ❌ Disabled 2025-01-30 13:34:44
Self hosted defaults ❌ Disabled 2025-01-30 13:34:44
Demo2 ❌ Disabled 2025-02-14 14:07:48

wip

feat: Adds unhealthy events reason

removes unused props

opens feature health tab when clicking warning description

try fix e2e

replace old history replace

addressing feedback

fix provider links position
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Feb 26, 2025
@tiagoapolo tiagoapolo merged commit 21aca25 into main Feb 26, 2025
33 checks passed
@tiagoapolo tiagoapolo deleted the feat/adds-reason-grafana branch February 26, 2025 18:39
khvn26 pushed a commit that referenced this pull request Feb 26, 2025
Copy link

flagsmith bot commented Feb 27, 2025

Flagsmith Feature feature_health has been updated:

Segment feature_health_beta_users values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2025-02-27 13:44:36

Copy link

flagsmith bot commented Mar 6, 2025

Flagsmith Feature feature_health has been updated:

Segment flagsmith_team values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2025-03-06 13:16:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants