fix: Show "Clear all" to the left of feature filters to prevent layout shift #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
|
Uffizzi Preview |
tiagoapolo
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting the first filter (or removing the last filter) on a list of features, "Clear all" appears/disappears to the right of the filter dropdowns, which causes layout shift. This is especially notable if a dropdown is open:
clear.all.mov
By moving "Clear all" to the left of the filters, we prevent most of the layout shift. There is still some layout shift when the number of selected filters (1) appears, but is much less noticeable and does not affect open dropdowns:
clear.all.new.mov