Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rtk segment identities #5121

Merged
merged 3 commits into from
Feb 19, 2025
Merged

chore: rtk segment identities #5121

merged 3 commits into from
Feb 19, 2025

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Feb 18, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Remove the segment identity provider and replaces with RTK
  • Adds search / pagination to the segments section of the user page
  • Fixes types for environment select

How did you test this code?

  • View a user's segments from the user page
  • View a segments identities from the segment modal

@kyle-ssg kyle-ssg requested a review from a team as a code owner February 18, 2025 11:06
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team February 18, 2025 11:06
@vercel Vercel
Copy link

vercel bot commented Feb 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 10:24am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 10:24am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 10:24am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Feb 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5121 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5121 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5121 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5121 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5121 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5121 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited
Loading

Uffizzi Preview deployment-61043 was deleted.

@kyle-ssg
Merge branch 'refs/heads/main' into chore/rtk-segment-identities
17696a5 
# Conflicts:
#	frontend/common/types/requests.ts
#	frontend/common/types/responses.ts
@github-actions github-actions bot added chore and removed chore labels Feb 19, 2025
@kyle-ssg kyle-ssg merged commit 951b216 into main Feb 19, 2025
18 of 20 checks passed
@kyle-ssg kyle-ssg deleted the chore/rtk-segment-identities branch February 19, 2025 10:21
@kyle-ssg kyle-ssg mentioned this pull request Feb 20, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoapolo tiagoapolo tiagoapolo approved these changes

Assignees
No one assigned
Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @tiagoapolo