Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hide SAML configuration frontend URL in SaaS #5102

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: Hide SAML configuration frontend URL in SaaS #5102

merged 1 commit into from
Feb 13, 2025

Conversation

rolodato
Copy link
Member

Context: #5091 (comment)

No reason to ever show the Frontend URL option for SAML configurations in SaaS. This PR hides it while keeping the same underlying behaviour.

@rolodato rolodato requested a review from a team as a code owner February 13, 2025 13:33
@rolodato rolodato requested review from kyle-ssg and removed request for a team February 13, 2025 13:33
@vercel Vercel
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 1:33pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 1:33pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 13, 2025 1:33pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5102 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5102 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5102 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5102 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5102 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5102 Finished ✅ Results ✅

@rolodato rolodato mentioned this pull request Feb 13, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Uffizzi Preview deployment-60891 was deleted.

@rolodato rolodato merged commit 82cdf8e into main Feb 13, 2025
33 checks passed
@rolodato rolodato deleted the feat/hide-saml-config-frontend-url-saas branch February 13, 2025 14:55
@flagsmithdev flagsmithdev mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoapolo tiagoapolo tiagoapolo approved these changes

@matthewelwell matthewelwell matthewelwell approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolodato @tiagoapolo @matthewelwell