-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Grafana feature health provider #5098
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5098 +/- ##
==========================================
+ Coverage 97.45% 97.46% +0.01%
==========================================
Files 1216 1224 +8
Lines 42368 42537 +169
==========================================
+ Hits 41289 41458 +169
Misses 1079 1079 ☔ View full report in Codecov by Sentry. |
4386d9e
to
ebdd756
Compare
@khvn26 this is an example of the logic I'm referring to with my comment here |
api/features/feature_health/migrations/0002_alter_featurehealthevent_external_id_and_more.py
Outdated
Show resolved
Hide resolved
- allow health providers to create multiple feature health events - add `FeatureHealthEvent.external_id` to track different alerts for one provider
- Add "Advanced Use > Feature Health" - Add Grafana Feature Health Provider docs - Improve Grafana Integration docs - Rename "APM" to "Observability"
ae4bcaa
to
7ffe3b6
Compare
@matthewelwell Reverted to TextField to avoid |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
This PR implements the Grafana (or Prometheus) health provider. Additionally, the feature health framework is refactored:
FeatureHealthEvent.created_at
can now be set to arbitrary datetime. This is done so we can use datetimes provided by alertmanager.FeatureHealthEvent.reason
is now aJSONField
with predetermined schema common for all providers. This enables supplying arbitrary number of text and URL data with the feature health event.How did you test this code?
Added integration tests: