Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make it more visible that user invites can be accepted by logging in, in addition to signing up #5077

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

rolodato
Copy link
Member

@rolodato rolodato commented Feb 5, 2025

When a user opens an invite link, by default they are prompted to sign up, which is the most likely course of action. If a user was previously removed from an organisation, or they already belong to a different organisation, they need to log in instead of signing up.

There is a prompt to log in, but it is difficult to see at the bottom of the page. I've had to explain too many times that this is an option - it makes more sense to offer it as an option before showing the sign up fields.

Lastly, "login" is a noun and not a verb. "Log in" is the correct phrasal verb.

Screenshot 2025-02-06 at 00 30 41 Screenshot 2025-02-06 at 00 30 51

@rolodato rolodato requested a review from a team as a code owner February 5, 2025 23:34
@rolodato rolodato requested review from kyle-ssg and removed request for a team February 5, 2025 23:34
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:34pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 11:34pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 5, 2025 11:34pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard chore labels Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5077 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5077 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5077 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5077 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5077 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5077 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Uffizzi Preview deployment-60665 was deleted.

@rolodato rolodato changed the title chore: Put "have an account? log in" at the top feat: Make it more visible that user invites can be accepted by logging in, in addition to signing up Feb 6, 2025
@rolodato rolodato merged commit d508e34 into main Feb 6, 2025
33 checks passed
@rolodato rolodato deleted the chore/existing-account-login branch February 6, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants