Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Feature health event task not working #5072

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Feb 3, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes the feature health events not being created in an environment where tasks are run asynchronously.

How did you test this code?

Ran task processor in a different container and triggered the webhook.

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 3:48pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 3:48pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 3:48pm

@khvn26 khvn26 marked this pull request as ready for review February 3, 2025 15:42
@khvn26 khvn26 requested a review from a team as a code owner February 3, 2025 15:42
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team February 3, 2025 15:42
@github-actions github-actions bot added the api Issue related to the REST API label Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5072 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5072 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5072 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5072 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5072 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5072 Finished ✅ Results

@khvn26 khvn26 force-pushed the fix/feature-health-event-task-not-working branch from 52a4df4 to 95eca6b Compare February 3, 2025 15:44
@khvn26 khvn26 changed the title Fix/feature health event task not working fix: Feature health event task not working Feb 3, 2025
@khvn26 khvn26 merged commit d4c4aaa into main Feb 3, 2025
35 checks passed
@khvn26 khvn26 deleted the fix/feature-health-event-task-not-working branch February 3, 2025 15:51
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (22223da) to head (89d6bcc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5072   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files        1214     1214           
  Lines       42264    42267    +3     
=======================================
+ Hits        41180    41183    +3     
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants