Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration-test): add decorator to skip if not enabled #5024

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jan 21, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add skipif mark to skip migration test if not enabled

How did you test this code?

By running test to with migration tests disabled

@gagantrivedi gagantrivedi requested a review from a team as a code owner January 21, 2025 10:45
@gagantrivedi gagantrivedi requested review from zachaysan and removed request for a team January 21, 2025 10:45
Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 10:46am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 10:46am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2025 10:46am

@github-actions github-actions bot added api Issue related to the REST API fix labels Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5024 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5024 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5024 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5024 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5024 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5024 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Uffizzi Preview deployment-60092 was deleted.

@matthewelwell matthewelwell merged commit 33cabfc into main Jan 21, 2025
33 checks passed
@matthewelwell matthewelwell deleted the fix/skip-migration-test branch January 21, 2025 10:58
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (3557e14) to head (5bbaf6e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5024   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files        1192     1192           
  Lines       41654    41657    +3     
=======================================
+ Hits        40571    40574    +3     
  Misses       1083     1083           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants