Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: add licensing to private installation #4947

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

matthewelwell
Copy link
Contributor

Changes

Adds licensing to private dependency installation

How did you test this code?

Verified that the following command installs the licensing package.

poetry install --with licensing

The images built as part of this PR should also confirm that the Dockerfile change works.

@matthewelwell matthewelwell requested a review from a team as a code owner January 2, 2025 14:56
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team January 2, 2025 14:56
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 3:22pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 3:22pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 3:22pm

@github-actions github-actions bot added the api Issue related to the REST API label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4947 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4947 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4947 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-4947 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-4947 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4947 Finished ✅ Results

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Uffizzi Preview deployment-59445 was deleted.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (95ebbdf) to head (8344a9f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4947   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files        1191     1191           
  Lines       41552    41552           
=======================================
  Hits        40470    40470           
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Jan 2, 2025
@matthewelwell matthewelwell merged commit fe949c8 into main Jan 6, 2025
35 checks passed
@matthewelwell matthewelwell deleted the deps/add-licensing-to-private-deps branch January 6, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants