Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add explicit pagination to change requests #4925

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

zachaysan
Copy link
Contributor

Changes

Adding explicit ordering for pagination concerns.

How did you test this code?

Did not test. It's a built-in Django practice.

@zachaysan zachaysan requested a review from a team as a code owner December 16, 2024 16:46
@zachaysan zachaysan requested review from matthewelwell and removed request for a team December 16, 2024 16:46
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 4:50pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 4:50pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 4:50pm

@github-actions github-actions bot added the api Issue related to the REST API label Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4925 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4925 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4925 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4925 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4925 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4925 Finished ✅ Results

@github-actions github-actions bot added the fix label Dec 16, 2024
@github-actions github-actions bot added fix and removed fix labels Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Uffizzi Preview deployment-59139 was deleted.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (e94e5c6) to head (efe65d4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4925   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files        1190     1191    +1     
  Lines       41530    41536    +6     
=======================================
+ Hits        40448    40454    +6     
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan merged commit cafb663 into main Dec 17, 2024
35 checks passed
@zachaysan zachaysan deleted the fix/add_explicit_pagination_to_change_requests branch December 17, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants