-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Relax Hubspot cookie tracking #4905
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
987fabc
Catch the integrity error
zachaysan ced5902
Test that the hubspot cookie collision doesn't raise an error
zachaysan 02a0246
Switch to inclusion check
zachaysan 0b526ff
Merge branch 'main' into fix/relax_hubspot_cookie_tracking
zachaysan bcd9037
Switch to user ids from emails
zachaysan 2380431
Merge branch 'main' into fix/relax_hubspot_cookie_tracking
zachaysan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -135,6 +135,40 @@ def test_non_superuser_can_create_new_organisation_by_default( | |
assert HubspotTracker.objects.filter(user=staff_user).exists() | ||
|
||
|
||
def test_colliding_hubspot_cookies_are_ignored( | ||
staff_client: APIClient, | ||
staff_user: FFAdminUser, | ||
admin_user: FFAdminUser, | ||
) -> None: | ||
# Given | ||
org_name = "Test create org" | ||
webhook_notification_email = "[email protected]" | ||
url = reverse("api-v1:organisations:organisation-list") | ||
colliding_cookie = "test_cookie_tracker" | ||
HubspotTracker.objects.create( | ||
user=admin_user, | ||
hubspot_cookie=colliding_cookie, | ||
) | ||
data = { | ||
"name": org_name, | ||
"webhook_notification_email": webhook_notification_email, | ||
HUBSPOT_COOKIE_NAME: colliding_cookie, | ||
} | ||
|
||
assert not HubspotTracker.objects.filter(user=staff_user).exists() | ||
|
||
# When | ||
response = staff_client.post(url, data=data) | ||
|
||
# Then | ||
assert response.status_code == status.HTTP_201_CREATED | ||
assert ( | ||
Organisation.objects.get(name=org_name).webhook_notification_email | ||
== webhook_notification_email | ||
) | ||
assert not HubspotTracker.objects.filter(user=staff_user).exists() | ||
|
||
|
||
@override_settings(RESTRICT_ORG_CREATE_TO_SUPERUSERS=True) | ||
def test_create_new_orgnisation_returns_403_with_non_superuser( | ||
staff_client: APIClient, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'd actually rather that we just log the user id here (and below) - I don't like the idea of logging emails if we can avoid it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that's no problem. I've switched the loggers to use user ids.