chore: investigate feature versions with invalid feature states #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4871 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 1186 1187 +1
Lines 41261 41294 +33
=======================================
+ Hits 40179 40212 +33
Misses 1082 1082 ☔ View full report in Codecov by Sentry. |
Docker builds report
|
matthewelwell
changed the title
matthewelwell
commented
Nov 28, 2024
Comment on lines
584
to
588
| "task_processor": { | ||
| "level": LOG_LEVEL, | ||
| "handlers": ["console"], | ||
| "propagate": False, | ||
| }, |
There was a problem hiding this comment.
@khvn26 good catch - the logging wasn't working correctly for the task processor. I'm not entirely sure why but I assume it's related to it having been moved to it's own package. I've re-added the configuration for it here in the meantime.
|
Superseded by #4872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds logging and exceptions to certain areas of the code to try and track down why we are seemingly seeing versions created with FeatureStates added from unrelated features.
How did you test this code?
Unit tests.