Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(admin): minor improvements #4862

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

matthewelwell
Copy link
Contributor

Changes

  1. Update auth-controller repository to fix registration issues with DomainAuthMethods admin
  2. Add OrganisationSubscriptionInformationCache as an inline to Organisation admin page

How did you test this code?

Ran the app locally and verified the admin pages.

@matthewelwell matthewelwell requested a review from a team as a code owner November 25, 2024 12:59
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team November 25, 2024 12:59
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 25, 2024 0:59am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Nov 25, 2024 0:59am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Nov 25, 2024 0:59am

@github-actions github-actions bot added api Issue related to the REST API chore labels Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4862 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4862 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4862 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4862 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4862 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4862 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Uffizzi Preview deployment-58547 was deleted.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (c0e3b3f) to head (5a9ecd4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4862   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files        1186     1186           
  Lines       41253    41261    +8     
=======================================
+ Hits        40171    40179    +8     
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit 94a7f49 into main Nov 26, 2024
34 checks passed
@matthewelwell matthewelwell deleted the chore/admin-improvements branch November 26, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants