Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle environment admin not being able to check VIEW_PROJECT permissions #4827

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: Handle environment admin not being able to check VIEW_PROJECT permissions #4827

merged 2 commits into from
Nov 12, 2024

Conversation

kyle-ssg
Copy link
Member

…ions

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Environment admins were not able to correctly view and manage environment permissions. This was due to it checking for VIEW_PROJECT permissions to detect any issues. This will now show an info banner for this usecase.

image

How did you test this code?

View permissions as an environment admin.

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 12, 2024 09:48
@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 10:00am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 10:00am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 10:00am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4827 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4827 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4827 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4827 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4827 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4827 Finished ✅ Results ✅

@github-actions github-actions bot added the fix label Nov 12, 2024
@kyle-ssg kyle-ssg linked an issue Nov 12, 2024 that may be closed by this pull request
Edit Environment Permissions fails without UI indication #2916
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Uffizzi Preview deployment-58175 was deleted.

@github-actions github-actions bot added fix and removed fix labels Nov 12, 2024
@kyle-ssg kyle-ssg merged commit 23ab3c1 into main Nov 12, 2024
30 checks passed
@kyle-ssg kyle-ssg deleted the fix/environment-admin-permissions branch November 12, 2024 14:38
@flagsmithdev flagsmithdev mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagantrivedi gagantrivedi gagantrivedi approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Environment Permissions fails without UI indication
2 participants
@kyle-ssg @gagantrivedi