Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: feature stale message not showing #4801

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix: feature stale message not showing #4801

merged 1 commit into from
Nov 5, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Nov 5, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

image

How did you test this code?

Verified stale messages show in all cases for compact / normal view mode

@kyle-ssg kyle-ssg requested a review from a team as a code owner November 5, 2024 14:08
@vercel Vercel
Copy link

vercel bot commented Nov 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:10pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:10pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Nov 5, 2024 2:10pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Nov 5, 2024
@kyle-ssg kyle-ssg linked an issue Nov 5, 2024 that may be closed by this pull request
Stale warning is not shown on all features in default view #4795
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4801 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4801 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4801 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4801 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4801 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4801 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Uffizzi Preview deployment-57952 was deleted.

@matthewelwell matthewelwell changed the title Fix feature stale message not showing fix: feature stale message not showing Nov 5, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 70a7d81 Nov 5, 2024
30 checks passed
@matthewelwell matthewelwell deleted the fix/feature-stale-message-not-showing branch November 5, 2024 15:03
@flagsmithdev flagsmithdev mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stale warning is not shown on all features in default view
2 participants
@kyle-ssg @matthewelwell