Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log Hubspot cookie creation #4778

Merged
merged 3 commits into from
Oct 29, 2024
Merged

feat: Log Hubspot cookie creation #4778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e8debd
Log Hubspot cookie creation
zachaysan Oct 28, 2024
9430243
Merge branch 'main' into feat/log_hubspot_cookie_creation
zachaysan Oct 28, 2024
19abb15
Add log test
zachaysan Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/integrations/lead_tracking/hubspot/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ def get_contact(self, user: FFAdminUser) -> None | dict[str, Any]:
def create_lead_form(
self, user: FFAdminUser, hubspot_cookie: str
) -> dict[str, Any]:
logger.info(
f"Creating Hubspot lead form for user {user.email} with hubspot cookie {hubspot_cookie}"
)
fields = [
{
"objectTypeId": "0-1",
Expand Down
3 changes: 2 additions & 1 deletion api/tests/unit/integrations/lead_tracking/hubspot/test_unit_hubspot_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,9 @@ def test_create_lead_form_error(
# Then
assert response == {"error": "Problem processing."}
assert inspecting_handler.messages == [
"Creating Hubspot lead form for user [email protected] with hubspot cookie test_hubspot_cookie",
"Problem posting data to Hubspot's form API due to 400 status code and following response: "
+ '{"error": "Problem processing."}'
+ '{"error": "Problem processing."}',
]


Expand Down
Loading