Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Frontend error when creating SAML configuration if API URL is relative #4751

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: Frontend error when creating SAML configuration if API URL is relative #4751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion frontend/web/components/modals/CreateSAML.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ const CreateSAML: FC<CreateSAML> = ({ organisationId, samlName }) => {
{ skip: !samlName },
)

const acsUrl = new URL(`/auth/saml/${name}/response/`, Project.api).href
const acsUrl = new URL(
`./auth/saml/${name}/response/`,
new Request(Project.api).url, // Project.api can be relative, e.g. /api/v1/
).href
const copyAcsUrl = async () => {
await navigator.clipboard.writeText(acsUrl)
toast('Copied to clipboard')
Expand Down
Loading