Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Trivy scan triggered when no scan requested #4742

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 16, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This fixes the build workflow failing for outside contributors.

How did you test this code?

This is a CI change.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 16, 2024 4:34pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Oct 16, 2024 4:34pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Oct 16, 2024 4:34pm

@github-actions github-actions bot added the fix label Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4742 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4742 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4742 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4742 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4742 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4742 Finished ✅ Results

@khvn26 khvn26 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 1ffef49 Oct 16, 2024
34 checks passed
@khvn26 khvn26 deleted the fix(ci)/trivy-scan-triggered-when-no-scan-requested branch October 16, 2024 16:39
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (2aad0a1) to head (118ccec).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4742   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files        1172     1172           
  Lines       40516    40516           
=======================================
  Hits        39390    39390           
  Misses       1126     1126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants