Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run eslint --fix removing all prettier error from web/ folder #4739

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

rssilva
Copy link
Contributor

@rssilva rssilva commented Oct 16, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

I temporarily changed eslint to

'extends': ['plugin:prettier/recommended'],
...
'rules': {},

and then ran eslint web/ --fix

@rssilva rssilva requested a review from a team as a code owner October 16, 2024 13:52
@rssilva rssilva requested review from kyle-ssg and removed request for a team October 16, 2024 13:52
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 2:26pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 2:26pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 2:26pm

Copy link

vercel bot commented Oct 16, 2024

@rssilva is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Uffizzi Preview deployment-57315 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 29, 2024
Merged via the queue into Flagsmith:main with commit 13494b6 Oct 29, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants