fix(versioning): handle versioned environments for associated-features endpoint #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
kyle-ssg and
zachaysan
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
front-end
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4735 +/- ##
=======================================
Coverage 97.21% 97.22%
=======================================
Files 1172 1172
Lines 40535 40569 +34
=======================================
+ Hits 39408 39443 +35
+ Misses 1127 1126 -1 ☔ View full report in Codecov by Sentry. |
matthewelwell
requested review from
a team and
khvn26
and removed request for
zachaysan and
a team
matthewelwell
force-pushed
the
fix/associated-features-endpoint
branch
from
4366e68 to
8a077c1
Compare
# Conflicts: # frontend/web/components/modals/AssociatedSegmentOverrides.js
khvn26
reviewed
Oct 28, 2024
| @@ -593,6 +593,10 @@ class Meta: | |||
| fields = ("id", "feature", "environment") | |||
|
|
|||
|
|
|||
| class AssociatedFeaturesQuerySerializer(serializers.Serializer): | |||
| environment = serializers.IntegerField(required=False) | |||
There was a problem hiding this comment.
Just a note to self — we do seem to have a convention to use entity, not entity_id, for query filters. The rule is only broken for the evaluation-data endpoint, which has an environment_id filter.
khvn26
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new query parameter to the
segments/:id/associated-features/endpoint which allows us to filter segment overrides by the current environment, and hence we can filter by latest versions.How did you test this code?
Added unit test for the API.
Tested FE changes locally.