Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Duplicated segment conditions on save #4726

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Updates segments when they are saved, fixing an issue whereby rules were duplicated after multiple saves.

How did you test this code?

  • Create a segment and save it then save it again
  • Update an already created segment then save it again

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 12, 2024 07:39
Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 11:18am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 11:18am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 11:18am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Oct 12, 2024
Copy link
Contributor

github-actions bot commented Oct 12, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4726 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4726 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4726 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4726 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4726 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4726 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 12, 2024

Uffizzi Preview deployment-57205 was deleted.

@kyle-ssg kyle-ssg linked an issue Oct 15, 2024 that may be closed by this pull request
4 tasks
@kyle-ssg kyle-ssg changed the title fix: segment on save fix: Duplicated segment conditions on save Oct 15, 2024
Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but noting this will make #3600 a lot more evident since it happens immediately on saving without needing to refresh.

@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 8825971 Oct 15, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the fix/update-segment-on-save branch October 15, 2024 15:35
matthewelwell pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segment conditions are duplicated when saving multiple updates and not refreshing
2 participants