Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removing segment overrides whilst adding others #4709

Merged
merged 4 commits into from
Oct 23, 2024
Merged

fix: Removing segment overrides whilst adding others #4709

merged 4 commits into from
Oct 23, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Oct 9, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Closes #4655

How did you test this code?

  • Opened existing segment overrides and removed one and added another

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 9, 2024 13:53
@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 4:00pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 4:00pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 4:00pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4709 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4709 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4709 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4709 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4709 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4709 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Uffizzi Preview deployment-57080 was deleted.

@kyle-ssg kyle-ssg marked this pull request as draft October 9, 2024 14:56
@github-actions github-actions bot added fix and removed fix labels Oct 15, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 15, 2024
@kyle-ssg
Merge branch 'refs/heads/main' into fix/delete_segment_override_and_a…
7af494d 
…dd_another

# Conflicts:
#	frontend/common/stores/feature-list-store.ts
@kyle-ssg kyle-ssg marked this pull request as ready for review October 15, 2024 15:57
@github-actions github-actions bot added fix and removed fix labels Oct 15, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 05f2bca Oct 23, 2024
49 checks passed
@matthewelwell matthewelwell deleted the fix/delete_segment_override_and_add_another branch October 23, 2024 09:53
@flagsmithdev flagsmithdev mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@rolodato rolodato Awaiting requested review from rolodato

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Percentage Override Not Saved When Modifying Segments
2 participants
@kyle-ssg @matthewelwell