Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: organisation integrations #4704

Merged
merged 9 commits into from
Oct 15, 2024
Merged

feat: organisation integrations #4704

merged 9 commits into from
Oct 15, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Oct 8, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds organisation integrations page. Integrations can be organisation level if the integration_data property has organisation: true.

image

image

Migrates integrations to typescript

How did you test this code?

Added , edited and deleted slack, github and grafana at project level, grafana and org level

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 8, 2024 18:04
@kyle-ssg kyle-ssg requested review from matthewelwell and removed request for a team October 8, 2024 18:04
@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:48am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 9:48am

@kyle-ssg kyle-ssg requested a review from khvn26 October 8, 2024 18:04
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4704 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4704 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-4704 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4704 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-4704 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4704 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4704 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4704 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4704 Finished ✅ Results ✅

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 8, 2024 18:07
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Uffizzi Preview deployment-57035 was deleted.

@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Oct 8, 2024
@kyle-ssg kyle-ssg linked an issue Oct 9, 2024 that may be closed by this pull request
Organisation level integrations #4434
Closed
zachaysan
zachaysan approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shared some optional feedback, but nothings a showstopper.

@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Oct 15, 2024
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Oct 15, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit d76a6f0 Oct 15, 2024
32 checks passed
@kyle-ssg kyle-ssg deleted the feat/organisation-integrations branch October 15, 2024 09:51
@flagsmithdev flagsmithdev mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaysan zachaysan zachaysan approved these changes

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

@khvn26 khvn26 Awaiting requested review from khvn26

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organisation level integrations
2 participants
@kyle-ssg @zachaysan