Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AttributeError when using LOGGING_CONFIGURATION_FILE environment variable #4693

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 3, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #4692.

How did you test this code?

Ran Flagsmith with LOGGING_CONFIGURATION_FILE as per the issue description.

@khvn26 khvn26 requested a review from a team as a code owner October 3, 2024 15:30
@khvn26 khvn26 requested review from matthewelwell and removed request for a team October 3, 2024 15:30
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 10:11am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 10:11am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 10:11am

@github-actions github-actions bot added the api Issue related to the REST API label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4693 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4693 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4693 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4693 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4693 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4693 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 3, 2024

Uffizzi Preview deployment-56892 was deleted.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (e65c8da) to head (c5ccdaa).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4693      +/-   ##
==========================================
+ Coverage   97.20%   97.22%   +0.01%     
==========================================
  Files        1171     1172       +1     
  Lines       40640    40516     -124     
==========================================
- Hits        39506    39390     -116     
+ Misses       1134     1126       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but codecov is failing.

@github-actions github-actions bot added fix and removed fix labels Oct 11, 2024
@github-actions github-actions bot added fix and removed fix labels Oct 16, 2024
@khvn26 khvn26 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 2aad0a1 Oct 16, 2024
35 checks passed
@khvn26 khvn26 deleted the fix/json-logging-attribute-error branch October 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError when using LOGGING_CONFIGURATION_FILE environment variable
2 participants