Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: encode search when querying features #4689

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: encode search when querying features #4689

merged 1 commit into from
Oct 2, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Oct 2, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Encodes search parameter for feature search

How did you test this code?

Searched features in the features and identity page

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 2, 2024 15:58
@kyle-ssg kyle-ssg requested review from matthewelwell and removed request for a team October 2, 2024 15:58
@vercel Vercel
Copy link

vercel bot commented Oct 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:00pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 4:00pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 2, 2024 4:00pm

@kyle-ssg kyle-ssg linked an issue Oct 2, 2024 that may be closed by this pull request
"@" Breaks page when entered in any search bar #4685
Closed
4 tasks
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4689 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4689 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4689 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4689 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4689 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4689 Finished ✅ Results ✅

@github-actions github-actions bot added the fix label Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Uffizzi Preview deployment-56860 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 7c746f4 Oct 2, 2024
25 of 31 checks passed
@kyle-ssg kyle-ssg deleted the fix/encode-characters-for-feature-search branch October 2, 2024 16:24
@flagsmithdev flagsmithdev mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"@" Breaks page when entered in any search bar
2 participants
@kyle-ssg @matthewelwell