Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle cancellation date for api usage #4672

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

zachaysan
Copy link
Contributor

Changes

Two small updates to the API usage alerting code that checks for subscription being cancelled and treating them as free accounts.

How did you test this code?

Two new tests.

@zachaysan zachaysan requested a review from a team as a code owner September 30, 2024 15:52
@zachaysan zachaysan requested review from khvn26 and removed request for a team September 30, 2024 15:52
Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Sep 30, 2024 3:52pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Sep 30, 2024 3:52pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Sep 30, 2024 3:52pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Sep 30, 2024
Copy link
Contributor

github-actions bot commented Sep 30, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4672 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4672 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4672 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4672 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4672 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4672 Finished ✅ Results

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

Uffizzi Preview deployment-56756 was deleted.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (dd1dd32) to head (93e8709).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4672   +/-   ##
=======================================
  Coverage   97.18%   97.19%           
=======================================
  Files        1166     1166           
  Lines       40369    40400   +31     
=======================================
+ Hits        39234    39265   +31     
  Misses       1135     1135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 17be366 Sep 30, 2024
35 checks passed
@zachaysan zachaysan deleted the fix/handle_cancellation_date_for_api_usage branch September 30, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants