feat: add MANAGE_TAGS permission #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Docker builds report
|
|
Uffizzi Preview |
github-actions
bot
added
feature
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4628 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 1162 1163 +1
Lines 40267 40285 +18
=======================================
+ Hits 39130 39148 +18
Misses 1137 1137 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
feature
matthewelwell
commented
Sep 16, 2024
| ) | ||
|
|
||
|
|
||
| def reverse(apps: Apps, schema_editor: BaseDatabaseSchemaEditor) -> None: # pragma: no cover |
There was a problem hiding this comment.
Justification for adding pragma: no cover here:
Considering the complexity of the code, and the very limited scope in which this code will ever be executed, I figured that it wasn't worth writing a migration test for it (since they are quite arduous to write).
I have tested the migration forwards and backwards manually.
khvn26
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the MANAGE_TAGS permission as per #4600
How did you test this code?
Added new unit test.