Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 404 when last organisation doesn't exist #4624

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

rolodato
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fix 404 when the last organisation doesn't exist - not exactly sure how this happens but probably involves removing a user from an org.

How did you test this code?

Not tested - I've landed on this route several times in production and it's the only place where it is referenced in code.

@rolodato rolodato requested a review from a team as a code owner September 12, 2024 12:30
@rolodato rolodato requested review from kyle-ssg and removed request for a team September 12, 2024 12:30
Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 0:31am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 0:31am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Sep 12, 2024 0:31am

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4624 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4624 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4624 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4624 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4624 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4624 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Uffizzi Preview deployment-56203 was deleted.

@rolodato rolodato added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit d60b3b7 Sep 12, 2024
31 checks passed
@rolodato rolodato deleted the fix/404-on-no-last-org branch September 12, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants