Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't include null traits in transient identifier #4598

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Sep 6, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #4597.

This clarifies typing and discards null traits from the transient identifier generation.

How did you test this code?

Added a null trait to corresponding integration test.

@khvn26 khvn26 requested a review from a team as a code owner September 6, 2024 20:35
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team September 6, 2024 20:35
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 9:02am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 9:02am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 9:02am

@github-actions github-actions bot added the api Issue related to the REST API label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4598 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4598 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4598 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4598 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4598 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4598 Finished ✅ Results

@github-actions github-actions bot added the fix label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Uffizzi Preview deployment-55983 was deleted.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (b2a1899) to head (c848da6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4598   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files        1157     1157           
  Lines       40023    40023           
=======================================
  Hits        38886    38886           
  Misses       1137     1137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 requested a review from matthewelwell September 8, 2024 17:08
@github-actions github-actions bot added fix and removed fix labels Sep 9, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 4bf7b9d Sep 9, 2024
35 checks passed
@matthewelwell matthewelwell deleted the fix/identities-type-error branch September 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: 'NoneType' object is not subscriptable
2 participants