-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect Java SDK installation and initialization code examples #4596
Merged
matthewelwell
merged 7 commits into
Flagsmith:main
from
SaptarshiSarkar12:4593-fix-sdk-install-and-init-code-example
Sep 13, 2024
Merged
fix: incorrect Java SDK installation and initialization code examples #4596
matthewelwell
merged 7 commits into
Flagsmith:main
from
SaptarshiSarkar12:4593-fix-sdk-install-and-init-code-example
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SaptarshiSarkar12 is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Uffizzi Preview |
matthewelwell
approved these changes
Sep 13, 2024
Thanks @SaptarshiSarkar12 ! |
Thank you @matthewelwell for reviewing and merging my PR ❤️! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
This PR fixes #4593 and brings the following changes 👇
version
xml tag and made changes to include</dependency>
as a part of the code example, in installing the sdk section5.0.0
to7.4.1
builder
method tonewBuilder()
underFlagsmithConfig
classHow did you test this code?
frontend
directory.npm ci
npm run dev
http://localhost:8080/
and create a test account.Environment
section and thenfeatures
from the side bar.