Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect Java SDK installation and initialization code examples #4596

Conversation

SaptarshiSarkar12
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This PR fixes #4593 and brings the following changes 👇

  • Added closing bracket to version xml tag and made changes to include </dependency> as a part of the code example, in installing the sdk section
  • Updated the version of maven and gradle dependencies from 5.0.0 to 7.4.1
  • Changed the builder method to newBuilder() under FlagsmithConfig class
  • Formatted the maven dependency code with tabs (4 spaces) to look clean and good

How did you test this code?

  1. Navigate to frontend directory.
  2. Run npm ci
  3. Run npm run dev
  4. Open http://localhost:8080/ and create a test account.
  5. Create a project after creating the organization.
  6. Click on Environment section and then features from the side bar.
  7. Checked the modified code examples by clicking in each of the two accordions.

@SaptarshiSarkar12 SaptarshiSarkar12 requested a review from a team as a code owner September 6, 2024 14:55
@SaptarshiSarkar12 SaptarshiSarkar12 requested review from kyle-ssg and removed request for a team September 6, 2024 14:55
Copy link

vercel bot commented Sep 6, 2024

@SaptarshiSarkar12 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 3:57pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Sep 9, 2024 3:57pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Sep 6, 2024
@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Fixed Java SDK installation and initialization code examples Fix: incorrect Java SDK installation and initialization code examples Sep 7, 2024
@matthewelwell matthewelwell changed the title Fix: incorrect Java SDK installation and initialization code examples fix: incorrect Java SDK installation and initialization code examples Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Uffizzi Preview deployment-56036 was deleted.

@matthewelwell
Copy link
Contributor

Thanks @SaptarshiSarkar12 !

@matthewelwell matthewelwell added this pull request to the merge queue Sep 13, 2024
Merged via the queue into Flagsmith:main with commit d12cf8b Sep 13, 2024
19 of 28 checks passed
@SaptarshiSarkar12
Copy link
Contributor Author

Thank you @matthewelwell for reviewing and merging my PR ❤️!

@SaptarshiSarkar12 SaptarshiSarkar12 deleted the 4593-fix-sdk-install-and-init-code-example branch September 13, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: The SDK initialisation code provided, is incorrect
2 participants