feat: Add domain to API flags blocked notification #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachaysan
requested review from
matthewelwell
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
zachaysan
changed the title
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4574 +/- ##
=======================================
Coverage 97.18% 97.18%
=======================================
Files 1164 1166 +2
Lines 40353 40369 +16
=======================================
+ Hits 39218 39234 +16
Misses 1135 1135 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Sep 13, 2024
api/organisations/templates/organisations/api_flags_blocked_notification.txt
Outdated
Show resolved
Hide resolved
…tification.txt Co-authored-by: Matthew Elwell <[email protected]>
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
github-actions
bot
added
feature
As discussed we decided that the level of work to test on staging was too high given the likelihood of the code operating as expected. |
zachaysan
deleted the
feat/add_domain_to_api_flags_blocked_notification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This changes our API flags blocked notification to the proper site domain.
How did you test this code?
Introspected the existing test to ensure that the new domain renders properly. Also, updated the test to pass.