Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update change request after create #4551

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

The frontend was unnecessarily updating change requests after creation, this was only needed for MV features. In addition the payload was also incorrect as it didn't include the ids of changesets

@kyle-ssg kyle-ssg requested a review from a team as a code owner August 28, 2024 16:57
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team August 28, 2024 16:57
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 4:58pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 4:58pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 28, 2024 4:58pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4551 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4551 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4551 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4551 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4551 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4551 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Uffizzi Preview deployment-55657 was deleted.

@matthewelwell matthewelwell removed the request for review from novakzaballa September 4, 2024 15:29
@matthewelwell
Copy link
Contributor

Fixes #4536

@matthewelwell
Copy link
Contributor

In testing this, I've created #4588 but I think it's unrelated to this issue as I can reproduce it in current production when change requests and versioning is enabled.

@kyle-ssg kyle-ssg added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit c353798 Sep 4, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the fix/update-change-request branch September 4, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
2 participants