Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: project settings permissions #4528

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: project settings permissions #4528

merged 1 commit into from
Aug 21, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes access check to Project Settings.

How did you test this code?

Logged in as project admin who can't currently see project settings.

@kyle-ssg kyle-ssg requested a review from a team as a code owner August 21, 2024 14:09
@kyle-ssg kyle-ssg requested review from novakzaballa and removed request for a team August 21, 2024 14:09
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4528 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4528 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4528 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4528 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4528 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4528 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

Uffizzi Preview deployment-55425 was deleted.

@khvn26
Copy link
Member

khvn26 commented Aug 21, 2024

pre-commit.ci run

@kyle-ssg kyle-ssg added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 9382908 Aug 21, 2024
32 checks passed
@kyle-ssg kyle-ssg deleted the fix/project-settings-link branch August 21, 2024 16:15
@kyle-ssg kyle-ssg linked an issue Aug 21, 2024 that may be closed by this pull request
Project admins cannot access Project Settings #4510
Closed
4 tasks
@flagsmithdev flagsmithdev mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project admins cannot access Project Settings
3 participants
@kyle-ssg @khvn26 @novakzaballa