Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tag Based permissions only validate some views #4523

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Solve #4287

How did you test this code?

Unit test added in the RBAC PR: https://github.com/Flagsmith/flagsmith-rbac/pull/26

@novakzaballa novakzaballa requested a review from a team as a code owner August 20, 2024 16:49
@novakzaballa novakzaballa requested review from gagantrivedi and removed request for a team August 20, 2024 16:49
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 8:40am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 8:40am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 8:40am

@github-actions github-actions bot added api Issue related to the REST API fix labels Aug 20, 2024
Copy link
Contributor

github-actions bot commented Aug 20, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4523 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4523 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4523 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4523 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4523 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4523 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 20, 2024

Uffizzi Preview deployment-57454 was deleted.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (1ffef49) to head (09a457a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4523      +/-   ##
==========================================
- Coverage   97.22%   97.21%   -0.01%     
==========================================
  Files        1172     1172              
  Lines       40516    40535      +19     
==========================================
+ Hits        39390    39408      +18     
- Misses       1126     1127       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@novakzaballa novakzaballa requested a review from zachaysan August 23, 2024 18:54
@gagantrivedi gagantrivedi force-pushed the fix/tag-based-permission-only-validate-some-views branch from a2c456c to 264116f Compare October 21, 2024 06:30
@github-actions github-actions bot removed the fix label Oct 21, 2024
@github-actions github-actions bot added the fix label Oct 21, 2024
@gagantrivedi gagantrivedi added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 6d2ab58 Oct 21, 2024
35 checks passed
@gagantrivedi gagantrivedi deleted the fix/tag-based-permission-only-validate-some-views branch October 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants