fix: allow unknown attrs from cb json meta #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
matthewelwell
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4509 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 1178 1178
Lines 39490 39492 +2
=======================================
+ Hits 38276 38278 +2
Misses 1214 1214 ☔ View full report in Codecov by Sentry. |
zachaysan
approved these changes
Aug 19, 2024
|
Sentry Issue: FLAGSMITH-API-4XK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue where adding elements to the metadata in a chargebee plan / add on causes an unhandled exception.
I'd like to move the SubscriptionMetadata classes to e.g. pydantic, but this is a quick solution to avoid too many conflicts with my other PR - #4433.
Resolves this sentry issue.
How did you test this code?
Updated an existing test to include an unknown key for both a plan and an addon.