fix: Solve API GitHub integration issues #4502
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4502 +/- ##
==========================================
- Coverage 96.92% 96.91% -0.01%
==========================================
Files 1178 1178
Lines 39474 39515 +41
==========================================
+ Hits 38260 38296 +36
- Misses 1214 1219 +5 ☔ View full report in Codecov by Sentry. |
| if self.type == "GITHUB_PR": | ||
| pattern = r"github.com/([^/]+)/([^/]+)/pull/\d+$" | ||
| elif self.type == "GITHUB_ISSUE": | ||
| pattern = r"github.com/([^/]+)/([^/]+)/issues/\d+$" |
There was a problem hiding this comment.
Maybe to future proof this it could be helpful to add an else keyword and raise an exception.
There was a problem hiding this comment.
I don't think it's necessary to implement this, because I am already validating it before creating the feature external resource here:
| github_configuration: GithubConfiguration, | ||
| github_repository: GithubRepository, |
There was a problem hiding this comment.
Nit:
| github_configuration: GithubConfiguration, | |
| github_repository: GithubRepository, | |
| github_configuration: GitHubConfiguration, | |
| github_repository: GitHubRepository, |
There was a problem hiding this comment.
I can't change this because it is the model's name.
There was a problem hiding this comment.
Ok I guess it's too much work to change the name of the model?
There was a problem hiding this comment.
I decided to rename the model, thanks for the suggestion. I will merge this PR afterward.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Solve #4500, and #4501
How did you test this code?
Unit test added