fix: deleting change requests with change sets throws 500 error #4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Docker builds report
|
matthewelwell
changed the title
khvn26
approved these changes
Jul 31, 2024
Comment on lines
271
to
282
| # live_from. | ||
| if first_feature_state := self.feature_states.order_by("live_from").first(): | ||
| return first_feature_state.live_from | ||
|
|
||
| # Then we do the same for environment feature versions. Note that a change request | ||
| # can not have feature states and environment feature versions. | ||
| # Then we check the change sets. | ||
| elif first_change_set := self.change_sets.order_by("live_from").first(): | ||
| return first_change_set.live_from | ||
|
|
||
| # Finally, we do the same for environment feature versions. | ||
| elif first_environment_feature_version := self.environment_feature_versions.order_by( | ||
| "live_from" | ||
| ).first(): |
There was a problem hiding this comment.
Just a design question — are we going to deprecate feature_states and environment_feature_versions in the future?
There was a problem hiding this comment.
I would like to, for sure, yep!
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4439 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 1170 1170
Lines 38786 38797 +11
=======================================
+ Hits 37566 37577 +11
Misses 1220 1220 ☔ View full report in Codecov by Sentry. |
matthewelwell
deleted the
fix(versioning)/handle-change-request-live_from-for-change-sets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes this Sentry issue.
How did you test this code?
Added a unit test.